Preliminary fix to add basepath to URL #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverhoeven
requested changes
Jan 8, 2025
There was a problem hiding this comment.
BASE_PATH=/class-web pnpm run build
mkdir class-web
cp -r ./apps/class-solid/.output/public/* class-web
python3 -m http.server
Goto http://localhost:888/class-web/ and created share link is
http://0.0.0.0:8000/class-web/_build#%7B%22experiments%22:%5B%7B%22name%22:%22My%20experiment%201%22,%22description%22:%22%22,%22reference%22:%7B%7D,%22permutations%22:%7B%7D%7D%5D%7D
The /_build should not be there. I think this is added by solid-start/vinxi
It works when I strip it away.
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
|
Thanks for the review @sverhoeven! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should work, but we can only know for sure once we make another release. @Chiil I don't want to do that right now as you might be in the middle of a demo.
Also would be good to have @sverhoeven check this once back from holiday.