This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
AVS-421_75 - Refactor to prevent errors when product is deleted #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsisco
commented
Feb 1, 2018
rsisco
commented
- Refactor code to use nulls when product is missing
- Addresses issue Fatal Error in Helper/TaxClass.php #104
- Refactor code to use nulls when product is missing
erikhansen
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
@rsisco I added two optional changes. You can merge this now or decide to make the changes.
Framework/Interaction/Line.php
Outdated
| { | ||
| $data = []; | ||
| if ($product) { | ||
| $data['itemCode'] = $this->taxClassHelper->getItemCodeOverride($product); |
There was a problem hiding this comment.
I would have created the $data array like this. However I'd say it's an optional refactor.
$data [
'itemCode' => $this->taxClassHelper->getItemCodeOverride($product),
'taxCode' => $this->taxClassHelper->getAvataxTaxCodeForProduct($product, $storeId),
'productRef1' => $this->taxClassHelper->getRef1ForProduct($product),
'productRef2' => $this->taxClassHelper->getRef2ForProduct($product)
]
Framework/Interaction/Line.php
Outdated
| // Using null values for these parameters since the product can no longer be found; they're null by default | ||
| // and only have values if explicitly defined in the configuration. Using nulls won't prevent submission to | ||
| // Avalara and will only raise an issue if the product had these values before being deleted. | ||
| $data['itemCode'] = null; |
There was a problem hiding this comment.
Same feedback as previous comment.
rsisco
deleted the
feature/AVS-421_75-refactor-to-prevent-error-when-product-is-deleted
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.