This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
Don't disable validation if it wasn't intentionally #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vovayatsyuk - I will review this proposed change and likely work it (or a version of it) into the next release of the extension. |
|
@vovayatsyuk - I've merged your code in and will include it in the next release. Thanks for the contribution. |
|
This has been included in version 1.4.8. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension Attributes is an object to store various third-party modules data.
So, it may not be null, but the code will disable validation in this case.
The patch fixes this logic and changes
$shouldValidateAddressflag, ifgetShouldValidateAddressis set.