This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
Feature/421 48 add support for split db #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsisco
commented
Apr 17, 2017
rsisco
commented
- Add support for Magento Enterprise's split database mode #54
- Refactor code to create AvaTax tables in the 'sales' database when running in split database mode
- Reference issue #54 for additional notes and details
added 4 commits
March 17, 2017 14:33
- Refactor code to create AvaTax tables in the 'sales' database when running in split database mode
…_48-add-support-for-split-db
- Revise changelog - Remove unnecessary connection name from DB update script
erikhansen
reviewed
Apr 17, 2017
There was a problem hiding this comment.
@rsisco Can you resolve the merge conflict with this PR? Also, I added a comment on the readme.
README.md
Outdated
| @@ -14,6 +14,8 @@ This extension contains integration tests to verify the extension's functionalit | |||
|
|
|||
| As of version 0.3.0 of this extension, this extension supported Magento 2.1.x (Community and Enterprise). Suppport for Magento 2.0.x was dropped as of version 0.3.0. See [this page](https://github.com/classyllama/ClassyLlama_AvaTax/releases) for a list of all releases. | |||
|
|
|||
| As of version 1.0.0 of this extension, this extension supports [Magento Enterprise's split database mode](http://devdocs.magento.com/guides/v2.1/config-guide/multi-master/multi-master.html). Reference issue [#54](https://github.com/classyllama/ClassyLlama_AvaTax/issues/54) for additional notes and details. | |||
There was a problem hiding this comment.
Can you remove the double spaces between these two sentences?
|
@erikhansen The merge conflict has been resolved and the edit made to the readme. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.