This repository has been archived by the owner on May 1, 2021. It is now read-only.
Remove PHP requirement in composer.json #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension isn't compatible with PHP 7.1 due to composer.json requirements. Considering that most 2.2+ sites will be using PHP 7.1+, this makes a big difference. Since the extension is essentially all javascript, I'm proposing that the PHP version constraint be removed entirely, rather than adding 7.1 and 7.2 to the list.
|
I see that the PHP requirement has been removed on |
added 2 commits
April 30, 2021 15:00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension isn't compatible with PHP 7.1 due to composer.json requirements.
Considering that most 2.2+ sites will be using PHP 7.1+, this makes a big difference.
Since the extension is essentially all javascript, I'm proposing that the PHP version constraint be removed entirely, rather than adding 7.1 and 7.2 to the list.