Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh actions with xapian wheels and caching #2

Closed
wants to merge 14 commits into from

Conversation

asedeno
Copy link

@asedeno asedeno commented Sep 23, 2021

Updated with xapian_wheel_builder.sh and caching.

One outstanding question is this: xapian_wheel_builder.sh is used with a new flag -t which adds xapian-delve to the wheel. Should we make that unconditional, or let non-test wheels be that much slimmer?

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

I'm going to make it unconditional. One less way to mess it up, and xapian-delve is already like 1% the size of libxapian so it's not a lot of overhead.

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

Now all the tests pass too, though there is an issue with coverage stuff that I'm not looking into.

@claudep
Copy link
Owner

claudep commented Sep 23, 2021

Thanks a lot! Coverage is not top priority for now, so if we don't find a solution now, we can deactivate it until later.

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

It looks like the coveralls issue is an issue in the coveralls action itself.
coverallsapp/github-action#30

@claudep
Copy link
Owner

claudep commented Sep 23, 2021

Feel free to remove it until a solution is found.

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

Let's try this. It doesn't work for me but I haven't tried to sign up for coveralls. Perhaps it'll work here or upstream?

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

It works now.

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

Well, kind of. It looks like some additional configuration is needed, but something will get uploaded to coveralls.

@asedeno
Copy link
Author

asedeno commented Sep 23, 2021

It's actually working now. The last bit was obvious in retrospect.

@asedeno asedeno changed the base branch from master to gh-actions September 24, 2021 01:17
@claudep
Copy link
Owner

claudep commented Sep 24, 2021

Thanks a ton!! I squashed commits to let only two commits and pushed that on the master branch. Hopefully done right!

@claudep claudep closed this Sep 24, 2021
@asedeno asedeno deleted the gh-actions branch September 24, 2021 18:16
@asedeno
Copy link
Author

asedeno commented Sep 24, 2021

Awesome. After that gets exercised some, we'll probably want to expand the test matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants