-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh actions with xapian wheels and caching #2
Conversation
1) `xapian_wheel_builder.sh` learns `-t`, which adds `xapian-delve` to the wheel 2) build with `-t` in the test workflow. 3) `tests/xapian_tests/tests/test_backend.py` learns to check the new `xapian-delve` location
I'm going to make it unconditional. One less way to mess it up, and |
We dropped support for xapian 1.2, when we dropped support for python2.
Now all the tests pass too, though there is an issue with coverage stuff that I'm not looking into. |
Thanks a lot! Coverage is not top priority for now, so if we don't find a solution now, we can deactivate it until later. |
It looks like the coveralls issue is an issue in the coveralls action itself. |
Feel free to remove it until a solution is found. |
Let's try this. It doesn't work for me but I haven't tried to sign up for coveralls. Perhaps it'll work here or upstream? |
It works now. |
Well, kind of. It looks like some additional configuration is needed, but something will get uploaded to coveralls. |
It's actually working now. The last bit was obvious in retrospect. |
Thanks a ton!! I squashed commits to let only two commits and pushed that on the master branch. Hopefully done right! |
Awesome. After that gets exercised some, we'll probably want to expand the test matrix. |
Updated with
xapian_wheel_builder.sh
and caching.One outstanding question is this:
xapian_wheel_builder.sh
is used with a new flag-t
which addsxapian-delve
to the wheel. Should we make that unconditional, or let non-test wheels be that much slimmer?