-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to pointer-events: none
on Sortable helper
#160
Conversation
src/SortableContainer/index.js
Outdated
@@ -288,6 +288,7 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f | |||
this.helper.style.width = `${this.width}px`; | |||
this.helper.style.height = `${this.height}px`; | |||
this.helper.style.boxSizing = 'border-box'; | |||
this.helper.style.pointerEvents = 'none'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
White space police! 🚓 Tab spotted!👮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
The one time I'm lazy and decide to use the built-in github editor 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never will I ever again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOTCHA! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier-bot would not have allowed this 🤖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(╯°□°)╯︵ ┻━┻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be time to step away from open source, Clauderic
fbb7c5b
to
e0c7f79
Compare
…r_events Default to `pointer-events: none` on Sortable helper
Why!! just why??!!? |
@clauderic Took me a while until I finally found why the cursor is not behaving as it is in the examples. Ahmedisam99 pointed it out already, in a rude manner though, that this change breaks the cursor styles. Would be nice if this was configurable. Also it's misleading that the Examples are not up-to-date where this change has not yet been made. |
Because... trackpad ninjas.
https://twitter.com/Vjeux/status/840264657424146436