Update LDAP authentication to support binding with user credentials #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamingHawk
force-pushed
the
ldap-enhancement
branch
from
81e4d69 to
8b0c4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common practice to anonymous binding for LDAP authentication, however the current implementation does not allow enough variance for passing through the user credentials.
This change allows the
bindDnandbindAuthenticationvariables to use the same{{x}}substitution used by thesearchFilterfurther upstream. This method also exposes the username and password fields for easy modification if required by particular non-standard implementations.When not used, there are no changes to existing functionality.