Adds basic support to css modules #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (not to be merged, at the moment) adds basic support for CSS modules to the project. It does it by:
style.dynamicallyGeneratedClassNamestyle for className property in Reactglobal.d.tsfor TypeScript to be able to "see" the styles.css module files (only for TS 2.0+) (thanks to @mohsen1 for the idea)What is missing is a proper loader which would create the
d.tsfile for each css module on the fly, so to be able for the editor to provide autocomplete feature and avoid using a global.d.ts.There are two or three options to do that (plus the changes in the WebPack configuration to deal with the dynamic generation of new files in the
srcdirectory), see this issue for a deeper discussion on the topic. As for the project goal, I try to avoid taking decisions on behalf of who is going to use starter kit for a serious project when they can have an impact on the final result.