-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all .mod files with make new #140
base: master
Are you sure you want to change the base?
Conversation
Determine all directories containing source files and remove any .mod files from these directories to avoid using old versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these new lists catch all .mod
files present in any source directory but does not remove the corresponding .o
file? Could this lead to some issues when a .mod
file is deleted and an .o
still exists?
Good question. In my tests it seemed to recompile as long as |
I think we still only to check to see if the |
Here's a version that removes all There's another line commented out that I couldn't get to work, using |
Oh, that is a bit scary. Probably why many call to the shell to do regular expression type stuff. Maybe we should put that warning in there just in case? |
We should just remove that version that is commented out -- I left it there in case you knew how to fix it. If there's a way to call to the shell and return the files identified by |
There are a few places that we could do this. There was a PR that had a python script that had some of these utilities. I might suggest that we raise an issue to do this but merge this in the mean time. |
This isn't urgent so let's hold off on merging for now and discuss some more. |
Determine all directories containing source files and remove any .mod files from these directories to avoid using old versions.
Previously a
.mod
file in a library such asamrclaw/src/2d
was not removed if the user had a custom version of the*_module.f90
file in a different directory, andmake new
would still use the old version when compiling other library routines thatuse
the module.I think this may eliminate some frustrations we've had with modules.
The
debug_new
target is useful for testing, but could be removed before merging to clean this up.