Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading output files in format binary32 #687

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Support reading output files in format binary32 #687

merged 9 commits into from
Jul 11, 2022

Conversation

rjleveque
Copy link
Member

Support reading fort.bxxxx files that are either binary64 == binary or binary32 format.

@rjleveque
support file_format binary32 to read as float32
f0715e1
@rjleveque
fix incorrect import for ascii case,
aba78eb 
seemed to work fine anyway, but this looks more correct.
@rjleveque
Support for binary32, and format is now in fort.t file...
43b2b87 
Added Solution.read_t function to read the file_format before importing
appropriate read function for ascii or binary.
@rjleveque
remove some debug statements
7cb6842
@rjleveque
fix fileio/binary.py to read aux arrays as binary32
1372ab3
@rjleveque
Merge branch 'master' into fgout_binary32
63ab807 
* master:
  add support for binary files containing float32 values
@rjleveque rjleveque mentioned this pull request Jun 2, 2022
Merged
@rjleveque
Copy link
Member Author

I think this works properly with clawpack/geoclaw#533, but it assumes that the fort.txxxx file for each frame includes a new line with the file_format (one of ascii, binary == binary64, or binary32) as described in clawpack/geoclaw#533, e.g. something like:

    0.30000000E+02    time
     4                 meqn
     4                 ngrids
     3                 naux
     2                 ndim
     2                 nghost
  ascii                format

This currently does not work with classic or amrclaw, but I am working on fixing that.

@mandli, @ketch: Does this require any other changes for pyclaw or petclaw when writing output files?

@rjleveque rjleveque mentioned this pull request Jun 3, 2022
Merged
@rjleveque
make read_t backward compatible if file_format is not in fort.t file
5ec349d
@rjleveque
new fileio.ascii.read_t function consolidates function previously def…
6e284b9 
…ined in 3 places

pyclaw.fileio.binary and pyclaw.solution now import from pyclaw.fileio.ascii
rather than having 3 versions that previously were not exactly consistent.
Also added except clause so that if file_format is not in the fort.t file,
it is backward compatible with output from running with a previous version.
@rjleveque
remove debug statment
da32c11
This was referenced Jun 17, 2022
Merged
Merged
@mandli mandli merged commit 85fab6a into clawpack:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjleveque @mandli