Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new component to show a sort by date dropdown #1407

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Adds new component to show a sort by date dropdown #1407

merged 4 commits into from
Jul 5, 2019

Conversation

manuelurenah
Copy link
Contributor

@manuelurenah manuelurenah commented May 9, 2019 •
edited
Loading

Description

  • Adds new dropdown button to sort pages by Recently Updated, Recently Published and Recently Scheduled.
  • Modifies styles in the page-list component
  • This is part of PR Custom sort #1404

QA

Screenshots

Screen Shot 2019-05-09 at 5 38 40 PM

fxisco
fxisco reviewed May 10, 2019
View reviewed changes
lib/nav/sort-selector.vue Outdated
@@ -0,0 +1,48 @@
<template>
<div class="sort-selector" :class="{ 'is-vertical': vertical }">
<ui-radio class="sort-selector-radio" color="accent" label="Recently Updated" :value="selectedSort" trueValue="updateTime" @input="input" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do a for loop here using a configuration object of array

lib/nav/sort-selector.vue
};
</script>

<style lang="sass">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put the styles at the beginning? I see this convention in others components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember the style convention for vue files is that style block should be at the bottom of the file, please see this issue https://github.com/clay/pyxis-frontend/issues/25

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 32.534% when pulling eb643d0 on dropdown-sort into 76cf42f on custom-sort.

@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 33.889% when pulling 31c8a06 on dropdown-sort into 974a6f9 on custom-sort.

@manuelurenah
Copy link
Contributor Author

Custom sort

@manuelurenah manuelurenah merged commit 89ce5b3 into custom-sort Jul 5, 2019
@manuelurenah manuelurenah deleted the dropdown-sort branch July 5, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxisco fxisco fxisco approved these changes

Assignees

@manuelurenah manuelurenah

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelurenah @coveralls @fxisco