Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple list: Update count when removing item #1483

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

MariaFdezJ
Copy link
Contributor

Fix

When you add an item to the list, it will update the list with the new item and increment the count, but if you remove the item from the list, the count is not decremented.

Copy link

@pedro-rosario pedro-rosario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Member

@james-owen james-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MariaFdezJ MariaFdezJ force-pushed the simple-list_decrease-count branch from 3cd712e to 8f44fda Compare October 9, 2019 19:02
@coveralls
Copy link

coveralls commented Oct 9, 2019

Coverage Status

Coverage increased (+0.7%) to 35.13% when pulling af8bf0e on simple-list_decrease-count into 13e22e3 on master.

inputs/simple-list.vue Show resolved Hide resolved
inputs/simple-list.test.js Outdated Show resolved Hide resolved
inputs/simple-list.test.js Show resolved Hide resolved
@MariaFdezJ MariaFdezJ requested a review from jjpaulino October 14, 2019 13:32
@MariaFdezJ MariaFdezJ merged commit a06e4c0 into master Oct 15, 2019
@MariaFdezJ MariaFdezJ deleted the simple-list_decrease-count branch October 15, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants