Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protects against invalid Quill links #1502

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Commits on Nov 11, 2020

  1. protects against invalid Quill links

    The default behavior when parsing a link in Quill:
    
    1. Check if link matches a list of valid protocols.
    2. If not, change link text to `about:blank`.
    
    Kiln wraps the `Link.sanitize` function to prepend `http://` in front
    of any link missing a protocol.
    
    As a result we can end up with invalid links like this:
    
    ```
    "http://one two three"
    ```
    
    This commit preserves the convenience factor of not **requiring** end
    users to enter a protocol, but validates that the link produced is a
    valid URL. Invalid URLs will revert to `about:blank`.
    
    This commit also changes the default protocol to `https://` which is a
    reasonable expectation and more secure default.
    mattoberle committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    b76df32 View commit details
    Browse the repository at this point in the history