-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New v5.0.0 version is always rebasing urls #54
Labels
Comments
Hey @eneko89 - can you please provide more details, as described in https://github.com/jakubpawlowicz/clean-css-cli/blob/master/CONTRIBUTING.md ? Thanks! |
Sure, I'll edit. |
eneko89
changed the title
New v5.0.0 version is always rebasing urls, even when --with-rebase is not used
New v5.0.0 version is always rebasing urls
Feb 10, 2021
Done @jakubpawlowicz. Btw, thanks for your quick response and sorry for the inconvenience 🙂 |
No problem @eneko89 Let me have a look at it! |
jakubpawlowicz
added a commit
that referenced
this issue
Feb 11, 2021
It's fixed in 5.0.1 on npm. Cheers! |
I can vouch for that. Thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Urls are getting rebased always, even when
--with-rebase
option is not used.Both of these rebase urls and produce the same results:
In the source css, I have font and img references like these:
And with v5.0.0, I get these urls in the minified file, both with and without
--with-rebase
:With previous v4.3.0, I used
--skip-rebase
and was getting:I'm running macOS Big Sur 11.2.
The text was updated successfully, but these errors were encountered: