Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New v5.0.0 version is always rebasing urls #54

Closed
eneko89 opened this issue Feb 10, 2021 · 6 comments
Closed

New v5.0.0 version is always rebasing urls #54

eneko89 opened this issue Feb 10, 2021 · 6 comments
Labels

Comments

@eneko89
Copy link

eneko89 commented Feb 10, 2021

Urls are getting rebased always, even when --with-rebase option is not used.

Both of these rebase urls and produce the same results:

cleancss assets/css/styles.css -o dist/css/styles.min.css
cleancss assets/css/styles.css -o dist/css/styles.min.css --with-rebase

In the source css, I have font and img references like these:

url('../fonts/roboto-400-latin.woff2')
url('../img/bg.jpg')

And with v5.0.0, I get these urls in the minified file, both with and without --with-rebase:

url('../../assets/fonts/roboto-400-latin.woff2')
url('../../assets/img/bg.jpg')

With previous v4.3.0, I used --skip-rebase and was getting:

url('../fonts/roboto-400-latin.woff2')
url('../img/bg.jpg')

I'm running macOS Big Sur 11.2.

@jakubpawlowicz
Copy link
Collaborator

Hey @eneko89 - can you please provide more details, as described in https://github.com/jakubpawlowicz/clean-css-cli/blob/master/CONTRIBUTING.md ? Thanks!

@eneko89
Copy link
Author

eneko89 commented Feb 10, 2021

Sure, I'll edit.

@eneko89 eneko89 changed the title New v5.0.0 version is always rebasing urls, even when --with-rebase is not used New v5.0.0 version is always rebasing urls Feb 10, 2021
@eneko89
Copy link
Author

eneko89 commented Feb 10, 2021

Done @jakubpawlowicz.

Btw, thanks for your quick response and sorry for the inconvenience 🙂

@jakubpawlowicz
Copy link
Collaborator

No problem @eneko89 Let me have a look at it!

@jakubpawlowicz
Copy link
Collaborator

It's fixed in 5.0.1 on npm. Cheers!

@eneko89
Copy link
Author

eneko89 commented Feb 11, 2021

I can vouch for that. Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants