Plug memleak i18nkeyboard #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://github.com/clear-code/fcitx5/tree/5.0.8+virtual-keyboard-squashed Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Cherry picking fcitx/fcitx5@80a9341 Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
INATALL_THEME => INSTALL_THEME Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
For following keyboard size. Note that this commit doesn't change MenuFont size because it's mainly for tray icon menu, so it should follow tray's font size. TODO: ClassicUI in this module should be renamed to VirtualKeyboardUI. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
With this change, no need to use RussianDummyKey class. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
With this change, no need to use RussianShiftToggleKey class. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
With this change, no need to use RussianNormalKey class. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Add custom keyboard layout specification
It should be U+1161. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Add template for GitHub Actions
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
It breaks CI when running with PR. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
ci: drop needless specifying branch
* Changed to use unique_ptr. * decrement reference count for json_object. Before: ==11333== LEAK SUMMARY: ==11333== definitely lost: 47,787 bytes in 120 blocks ==11333== indirectly lost: 11,202,985 bytes in 105,883 blocks ==11333== possibly lost: 46,244 bytes in 682 blocks ==11333== still reachable: 20,012,541 bytes in 82,152 blocks ==11333== of which reachable via heuristic: ==11333== length64 : 152,752 bytes in 377 blocks ==11333== newarray : 1,568 bytes in 18 blocks ==11333== multipleinheritance: 3,816 bytes in 46 blocks ==11333== suppressed: 0 bytes in 0 blocks After: ==45659== LEAK SUMMARY: ==45659== definitely lost: 47,851 bytes in 118 blocks ==45659== indirectly lost: 11,006,651 bytes in 104,111 blocks ==45659== possibly lost: 200,985 bytes in 1,977 blocks ==45659== still reachable: 20,011,558 bytes in 82,145 blocks ==45659== of which reachable via heuristic: ==45659== length64 : 152,752 bytes in 377 blocks ==45659== newarray : 1,568 bytes in 18 blocks ==45659== multipleinheritance: 14,136 bytes in 158 blocks ==45659== suppressed: 0 bytes in 0 blocks Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Fix memleaks
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.