Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Cleanup unfinished sessions and unclaimed tokens on UnregisterVM #66

Open
dlespiau opened this issue May 26, 2017 · 0 comments
Open

Cleanup unfinished sessions and unclaimed tokens on UnregisterVM #66

dlespiau opened this issue May 26, 2017 · 0 comments
Assignees
@jcvenegas
Labels
post-release

Comments

@dlespiau
Copy link
Contributor

It's possible that we've been asked for shim tokens but never managed to fully start the container for some reason. When the runtime tries to clean up in the error path by calling UnregisterVM, we should make sure we clean up all objects associated with the VM in the proxy struct.

And test it.
@dlespiau dlespiau self-assigned this May 28, 2017
@egernst egernst assigned amshinde and unassigned dlespiau Aug 10, 2017
@amyleeland amyleeland assigned jcvenegas and unassigned amshinde Aug 14, 2017
jcvenegas added a commit to jcvenegas/cc-proxy that referenced this issue Aug 21, 2017
@jcvenegas
proxy: unregisterVM free token
16e8c2f 
When unregisterVM is called we want to free all the tokens we register
previously, all the tokens should not be valid anymore.

Fixes: clearcontainers#66

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
@jcvenegas jcvenegas mentioned this issue Aug 21, 2017
Closed
jcvenegas added a commit to jcvenegas/cc-proxy that referenced this issue Aug 21, 2017
@jcvenegas
proxy: unregisterVM free token
6f65d45 
When unregisterVM is called we want to free all the tokens we register
previously, all the tokens should not be valid anymore.

Fixes: clearcontainers#66

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas added a commit to jcvenegas/cc-proxy that referenced this issue Aug 21, 2017
@jcvenegas
proxy: unregisterVM free token
f661105 
When unregisterVM is called we want to free all the tokens we register
previously, all the tokens should not be valid anymore.

Fixes: clearcontainers#66

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jcvenegas jcvenegas

Labels
post-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dlespiau @amyleeland @amshinde @egernst @jcvenegas