Skip tests that require two builds in a format when there's only one #1634
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already detect and report that certain tests require at least two builds within the current format, but only one exists. Change that from a test *failure* to a *skip*. Example: We need at least 2 versions in format 38 to continue with this test Test teardown complete. not ok 2 RCT002: Repair a big system # (from function `test_setup' in file test/real_content/real_content_lib.bash, line 144, # from function `setup' in test file test/real_content/../functional/testlib.bash, line 4647) # `test_setup' failed # becomes: ok 2 RCT002: Repair a big system # skip We need at least 2 versions in format 38 to continue with this test
bryteise
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already detect and report that certain tests require at least two builds within the current format, but only one exists. Change that from a test failure to a skip.
Example:
becomes: