Skip to content

Fixes #39 Implements Negative Difference Threshold #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2024
Merged

Fixes #39 Implements Negative Difference Threshold #54

merged 3 commits into from
May 16, 2024

Conversation

@tm1000
Copy link
Member

@tm1000 tm1000 commented May 16, 2024 •
edited
Loading

Fixes #39

@tm1000 tm1000 self-assigned this May 16, 2024
@tm1000 tm1000 mentioned this pull request May 16, 2024
Closed
GameGamer43
GameGamer43 previously approved these changes May 16, 2024
View reviewed changes
berrugo
berrugo previously approved these changes May 16, 2024
View reviewed changes
bsandstrom
bsandstrom previously approved these changes May 16, 2024
View reviewed changes
@tm1000 tm1000 dismissed stale reviews from bsandstrom, berrugo, and GameGamer43 via a259d87 May 16, 2024 20:35
@tm1000 tm1000 merged commit bc4a403 into main May 16, 2024
@github-actions
Copy link

github-actions bot commented May 16, 2024

Code Coverage Report

Code Coverage

Package Base Coverage New Coverage Difference
main.ts 🔴 0% 🔴 0% ⚪ 0%
reports/clover/index.ts 🟢 100% 🟢 100% ⚪ 0%
reports/clover/parser/index.ts 🟢 84.31% 🟢 84.31% ⚪ 0%
reports/clover/types/index.ts 🟢 100% 🟢 100% ⚪ 0%
reports/cobertura/index.ts 🟢 100% 🟢 100% ⚪ 0%
reports/cobertura/parser/index.ts 🟢 92.31% 🟢 92.31% ⚪ 0%
reports/cobertura/types/index.ts 🟢 100% 🟢 100% ⚪ 0%
utils.ts 🟠 72.22% 🟠 72.57% 🟢 0.35%
Overall Coverage 🟢 54.58% 🟢 54.53% 🔴 -0.05%

Minimum allowed coverage is 0%, this run produced 54.53%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GameGamer43 GameGamer43 GameGamer43 left review comments

@berrugo berrugo berrugo left review comments

@bsandstrom bsandstrom bsandstrom left review comments

Assignees

@tm1000 tm1000

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

negative_difference_threshold is not working.

5 participants

@tm1000 @GameGamer43 @berrugo @bsandstrom