Address some Client SCA issues #145

dtebbs · 2020-01-15T12:49:27Z

Related to #144

dtebbs · 2020-01-15T12:49:50Z

Currently WIP while the document is discussed and finalized.

AntoineRondelet · 2020-02-04T10:57:56Z

pyClient/commands/utils.py

+                for out_ev in mix_result.output_events:
+                    merkle_tree.set_entry(
+                        out_ev.commitment_address, out_ev.commitment)
+                new_merkle_root = mix_result.new_merkle_root


Storing the entire Merkle Tree will be very expensive for the clients (2^{depth + 1} - 1 nodes to store, so if depth is set to 32, the storage requirements for the client will be very important). Instead of storing the full MK tree, the client is only interested in storing the nodes required to generate Merkle authentication paths for the commitments the client user "owns" (i.e.knows the opening for).
This may lead to various SCAs on the client itself, but won't be exploitable at the networking level which is what this PR seems to address

Note: this does not need to be addressed on this PR, but is something to be aware of, and document for further iterations on the client.

Yes. Noted for future work and documentation.

AntoineRondelet · 2020-02-06T09:01:59Z

pyClient/commands/constants.py

@@ -20,3 +20,5 @@

 WALLET_DIR_DEFAULT = "./notes"
 WALLET_USERNAME = "zeth"
+
+MERKLE_TREE_FILE_DEFAULT = "./merkle_tree"


Let's be consistent with the naming of the constants:
In the same file you have:
INSTANCEFILE_DEFAULT = "zeth-instance.json", ADDRESSFILE_DEFAULT = "zeth-address.json" (FILE is concatenated directly without _), and now you declare MERKLE_TREE_FILE_DEFAULT = "./merkle_tree", with a _FILE.

Let's stick to _FILE everywhere.

Also, let's use file extensions in order to inform on how the data is stored and should be read (.dat can be used for generic data files)

Chaged to _FILE_ everywhere, and used .dat for merkle tree data.

AntoineRondelet · 2020-02-06T09:37:10Z

pyClient/commands/zeth_ls_commits.py

-    mixer_desc = load_mixer_description_from_ctx(ctx)
-    zeth_instance = mixer_desc.mixer.instantiate(web3)
-    null = bytes(32)
+    merkle_tree = open_merkle_tree(ctx)


open_merkle_tree should receive a Context, so let's switch to Context instead of Any in the signature of the ls_commit function

Used Context everywhere.

AntoineRondelet · 2020-02-06T09:38:43Z

pyClient/commands/zeth_ls_notes.py

 @pass_context
-def ls_notes(ctx: Any) -> None:
+def ls_notes(ctx: Any, balance: bool, spent: bool) -> None:


Same here, Any should be Context

Thanks @dtebbs. I like the changes you have made to display the balance and the spent notes!

AntoineRondelet · 2020-02-06T09:39:50Z

pyClient/test/test_merkle_tree.py

+from unittest import TestCase
+
+MERKLE_TREE_TEST_DIR = "_merkle_tests"
+MERKLE_TREE_TEST_SIZE = 16


Let's rename this constant to be clearer. I imagine that by "size" you mean the nb of leaves, so what about MERKLE_TREE_TEST_LEAVES?

Renamed the constant.

Address some Client SCA issues

dtebbs force-pushed the client-sca-issues branch from b2913a6 to 853385a Compare January 17, 2020 15:39

dtebbs force-pushed the contract-performance branch from 7c93998 to 7bf9a31 Compare January 17, 2020 15:39

dtebbs force-pushed the client-sca-issues branch from 9d4113a to 4052f36 Compare January 17, 2020 17:41

dtebbs force-pushed the contract-performance branch 3 times, most recently from 896c503 to 28bb7de Compare January 21, 2020 18:30

dtebbs force-pushed the client-sca-issues branch 2 times, most recently from 9f8b88e to e37dedd Compare January 27, 2020 12:11

dtebbs force-pushed the contract-performance branch 4 times, most recently from 66bb45b to 9b0abbe Compare January 30, 2020 17:46

dtebbs force-pushed the client-sca-issues branch from e37dedd to af4da2d Compare January 30, 2020 17:53

dtebbs changed the title ~~WIP: Address some Client SCA issues (depends on #138)~~ Address some Client SCA issues (depends on #138) Jan 31, 2020

dtebbs mentioned this pull request Jan 31, 2020

Benchmarks at depth 32 #154

Merged

AntoineRondelet reviewed Feb 4, 2020

View reviewed changes

dtebbs force-pushed the client-sca-issues branch from af4da2d to 5fb2d1d Compare February 4, 2020 15:14

dtebbs force-pushed the contract-performance branch from 1b9f697 to 4be1c1b Compare February 5, 2020 09:48

dtebbs changed the base branch from contract-performance to develop February 5, 2020 15:57

dtebbs changed the title ~~Address some Client SCA issues (depends on #138)~~ Address some Client SCA issues Feb 5, 2020

dtebbs added 9 commits February 5, 2020 16:34

pyclient: resurect python implementation of mimc with tests

0615fec

pyclient: data structure for event log data from mixer

48fe28a

pyclient: proof-of-concept persistent merkle tree structure

3ee7ae8

pyclient: better naming for event data

c6a21d2

pyclient: consistent merkle root type

1e0a754

pyclient: keep local list of commitments and avoid querying contract

d55f270

contracts: remove all public methods except mix

52f12b1

contracts: emit nullifiers from contracts

c0671fd

pyclient: parse nullifier events from mix calls

cd767b9

dtebbs added 5 commits February 5, 2020 16:36

pyclient: maintain map of nullifier to note commitment

10ff58e

pyclient: use nullifier map to mark spent notes

8e50940

pyclient: support showing balance and listing spent notes

ba0b29e

pyclient: keep only the populated leaves of the Merkle tree of commits

c8c84d8

.travis: remove unused apt package

5335eb7

dtebbs force-pushed the client-sca-issues branch from 5fb2d1d to 5335eb7 Compare February 5, 2020 16:36

AntoineRondelet reviewed Feb 6, 2020

View reviewed changes

dtebbs added 3 commits February 6, 2020 17:28

pyclient: consistent constant naming

503bbe0

pyclient: more use of Context type

b265127

pyclient: change constant name in unit test

eddc4c4

AntoineRondelet merged commit a2ce0e3 into develop Feb 7, 2020

AntoineRondelet deleted the client-sca-issues branch February 26, 2020 12:25

AntoineRondelet added a commit that referenced this pull request May 6, 2020

Merge pull request #145 from clearmatics/client-sca-issues

d1aa33e

Address some Client SCA issues

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address some Client SCA issues #145

Address some Client SCA issues #145

dtebbs commented Jan 15, 2020 •

edited

Loading

dtebbs commented Jan 15, 2020

AntoineRondelet Feb 4, 2020

AntoineRondelet Feb 4, 2020

dtebbs Feb 4, 2020 •

edited

Loading

AntoineRondelet Feb 6, 2020

AntoineRondelet Feb 6, 2020

dtebbs Feb 6, 2020

AntoineRondelet Feb 6, 2020

dtebbs Feb 6, 2020

AntoineRondelet Feb 6, 2020

dtebbs Feb 6, 2020

AntoineRondelet Feb 7, 2020

AntoineRondelet Feb 6, 2020 •

edited

Loading

dtebbs Feb 6, 2020

Address some Client SCA issues #145

Address some Client SCA issues #145

Conversation

dtebbs commented Jan 15, 2020 • edited Loading

dtebbs commented Jan 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtebbs Feb 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AntoineRondelet Feb 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtebbs commented Jan 15, 2020 •

edited

Loading

dtebbs Feb 4, 2020 •

edited

Loading

AntoineRondelet Feb 6, 2020 •

edited

Loading