Build flag management #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #198 Overview:
(Note, the rationale here is that during development it can be useful to allow some warnings, but warnings should be caught in pushed code. We can moify this if there are differing opinions.) |
dtebbs
force-pushed
the
build-flags
branch
3 times, most recently
from
c100625
to
d7683a0
Compare
Merged
|
|
||
| namespace | ||
| { | ||
|
|
||
| fs::path g_testdata_dir = fs::path("..") / "testdata"; |
There was a problem hiding this comment.
Wouldn't it be possible to use an environment variable here? Otherwise we need to assume that the tests are written from a specific location (else, we end up writing testdata in the user's filesystem)
There was a problem hiding this comment.
Oh, just realized that you overwrote this global variable before running the tests..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.