libzeth tests structure #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dtebbs
commented
May 6, 2020
•
dtebbs
commented
- Test file layout to match libzeth code
- Added tests for several components (more required)
- Fixed some duplicated code, ambiguous interfaces (particularly around endianness) and inefficient implementations.
dtebbs
force-pushed
the
clean-libzeth-tests
branch
from
c62f6ad
to
c3bfcfd
Compare
…some low-level encoding tests
dtebbs
force-pushed
the
clean-libzeth-tests
branch
from
c3bfcfd
to
c81c3af
Compare
dtebbs
force-pushed
the
clean-libzeth-tests
branch
from
c2f942f
to
c81c3af
Compare
dtebbs
force-pushed
the
clean-libzeth-tests
branch
from
c81c3af
to
5ec5fcd
Compare
dtebbs
force-pushed
the
clean-libzeth-tests
branch
from
5ec5fcd
to
cb749d8
Compare
|
@AntoineRondelet thanks for the comments. I believe everything is addressed, but let me know if there are any remaining points. |
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
libzeth tests structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.