Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic serialization of field and group elements (contains #220) (depends on #233) #232

Merged
merged 24 commits into from
Jul 28, 2020
Merged

Generic serialization of field and group elements (contains #220) (depends on #233) #232

merged 24 commits into from
Jul 28, 2020

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Jul 24, 2020

No description provided.

@dtebbs dtebbs changed the base branch from api-group-elements-refactor to develop July 24, 2020 13:43
@dtebbs dtebbs changed the title WIP: Generic serialization of field and group elements WIP: Generic serialization of field and group elements (contains #220) Jul 24, 2020
@dtebbs dtebbs force-pushed the api-group-elements-generic branch from 62fd333 to 86d8b9c Compare July 24, 2020 16:43
@dtebbs dtebbs changed the base branch from develop to fix-type-naming July 27, 2020 15:23
@dtebbs dtebbs force-pushed the api-group-elements-generic branch from 7abc6b3 to da08c0a Compare July 27, 2020 15:24
@dtebbs dtebbs changed the title WIP: Generic serialization of field and group elements (contains #220) Generic serialization of field and group elements (contains #220) (depends on #233) Jul 27, 2020
@AntoineRondelet AntoineRondelet mentioned this pull request Jul 28, 2020
Closed
@dtebbs dtebbs force-pushed the api-group-elements-generic branch from da08c0a to 01be836 Compare July 28, 2020 09:19
AntoineRondelet and others added 19 commits July 28, 2020 10:27
@AntoineRondelet @dtebbs
Modified proto message for elements of G2 to support extension fields…
58ee921 
… of arbitrary degrees
@AntoineRondelet @dtebbs
Cleaned the comments in ec_group proto file
d40c234
@AntoineRondelet @dtebbs
Updated libsnark to bring exposed extension degrees to scope
bb0f53d
@AntoineRondelet @dtebbs
Wrote extension field element serialization function
853ebe1
@AntoineRondelet @dtebbs
Fixed tests for encode/decode of exttension field elements
91c4db4
@AntoineRondelet @dtebbs
Switched functions in group element serialization and in proto utils
8486030
@AntoineRondelet @dtebbs
Ran formatting script
379fdb9
@AntoineRondelet @dtebbs
Fixed group element encoding
3e129a5
@AntoineRondelet @dtebbs
Improved documentation comments and removed unused variables
f879806
@AntoineRondelet @dtebbs
Cast repeated protobuf field to tuple of str and fixed serialization
f4b20b6
@AntoineRondelet @dtebbs
Used reverse iterators to fix decoding function and minor cleanup
a8c4dd6
@AntoineRondelet @dtebbs
Fixed type annotation
2790926
@AntoineRondelet @dtebbs
Built extension field element using new constructor from array
c8e7080
@dtebbs
fixed group element encoding
57d8393
@AntoineRondelet @dtebbs
Updated libsnark submodule
1163fca
@dtebbs
libzeth: support 0x prefix in hex utils
26ab95b
@dtebbs
Generic field serialization
200cef4
@dtebbs
libzeth: generic JSON encoding / decoding of group elements
681c479
@dtebbs
generic group serialization functions
35f59f2
@dtebbs dtebbs force-pushed the api-group-elements-generic branch from 01be836 to 689466d Compare July 28, 2020 09:27
@AntoineRondelet AntoineRondelet changed the base branch from fix-type-naming to develop July 28, 2020 13:26
@AntoineRondelet
Copy link
Contributor

LGTM, I changed the base branch to point to develop, in which I merged the fix-type-naming branch

@AntoineRondelet AntoineRondelet merged commit bc034b4 into develop Jul 28, 2020
@AntoineRondelet AntoineRondelet deleted the api-group-elements-generic branch July 28, 2020 17:52
@AntoineRondelet AntoineRondelet mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet