Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize mimc gadget #323

Merged
merged 13 commits into from
Dec 10, 2020
Merged

Parameterize mimc gadget #323

merged 13 commits into from
Dec 10, 2020

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Dec 2, 2020

No description provided.

@dtebbs dtebbs changed the base branch from zeth-bls12-377 to develop December 3, 2020 10:17
@dtebbs dtebbs changed the title WIP: parameterize mimc gadget Parameterize mimc gadget Dec 3, 2020
AntoineRondelet
AntoineRondelet reviewed Dec 8, 2020
View reviewed changes
libzeth/circuits/mimc/mimc_permutation_gadget.hpp Outdated Show resolved Hide resolved
libzeth/core/utils.hpp Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_round_gadget.tcc Outdated Show resolved Hide resolved
libzeth/circuits/circuit_types.hpp Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_permutation_gadget.hpp Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_round_gadget.tcc Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_round_gadget.tcc Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_round_gadget.tcc Outdated Show resolved Hide resolved
libzeth/core/utils.tcc Outdated Show resolved Hide resolved
libzeth/tests/circuits/merkle_tree_test.cpp Outdated Show resolved Hide resolved
@dtebbs dtebbs force-pushed the mimc-gadget-exp-parameter branch 3 times, most recently from 83893db to 067c13b Compare December 8, 2020 16:43
@dtebbs dtebbs mentioned this pull request Dec 8, 2020
Merged
AntoineRondelet
AntoineRondelet reviewed Dec 10, 2020
View reviewed changes
libzeth/circuits/mimc/mimc_round.tcc Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_round.tcc Outdated Show resolved Hide resolved
@AntoineRondelet
Copy link
Contributor

Thanks @dtebbs LGTM

@AntoineRondelet AntoineRondelet merged commit 8a04d0e into develop Dec 10, 2020
@AntoineRondelet AntoineRondelet deleted the mimc-gadget-exp-parameter branch December 21, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet