Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in preparation for proof input hasing #344

Merged
merged 14 commits into from
Jan 29, 2021
Merged

Changes in preparation for proof input hasing #344

merged 14 commits into from
Jan 29, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Jan 13, 2021

No description provided.

@dtebbs dtebbs removed the request for review from AntoineRondelet January 13, 2021 17:16
@dtebbs dtebbs changed the title Changes in preparation for proof input hasing [WIP] Changes in preparation for proof input hasing Jan 13, 2021
@dtebbs dtebbs force-pushed the input-hashing-prepare branch 5 times, most recently from dc77ff4 to a94c795 Compare January 14, 2021 18:11
@dtebbs dtebbs changed the title [WIP] Changes in preparation for proof input hasing [WIP] Changes in preparation for proof input hasing (depends on #343) Jan 14, 2021
@dtebbs dtebbs changed the title [WIP] Changes in preparation for proof input hasing (depends on #343) Changes in preparation for proof input hasing (depends on #343) Jan 15, 2021
@AntoineRondelet AntoineRondelet changed the base branch from zecale-support to develop January 18, 2021 18:34
AntoineRondelet
AntoineRondelet reviewed Jan 19, 2021
View reviewed changes
client/zeth/core/input_hasher.py Outdated Show resolved Hide resolved
client/zeth/core/prover_client.py Outdated Show resolved Hide resolved
libzeth/circuits/circuit_wrapper.hpp Show resolved Hide resolved
libzeth/circuits/circuit_wrapper.tcc Show resolved Hide resolved
libzeth/circuits/joinsplit.tcc Show resolved Hide resolved
libzeth/circuits/merkle_tree/merkle_path_compute.hpp Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_input_hasher.tcc Outdated Show resolved Hide resolved
libzeth/circuits/mimc/mimc_input_hasher.tcc Outdated Show resolved Hide resolved
@dtebbs dtebbs changed the title Changes in preparation for proof input hasing (depends on #343) Changes in preparation for proof input hasing Jan 21, 2021
AntoineRondelet
AntoineRondelet reviewed Jan 29, 2021
View reviewed changes
libzeth/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
libzeth/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
@AntoineRondelet AntoineRondelet added the zecale-integration Task related to the custom integration of Zeth with Zecale label Jan 29, 2021
AntoineRondelet
AntoineRondelet approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRondelet AntoineRondelet merged commit 024e9dc into develop Jan 29, 2021
AntoineRondelet added a commit that referenced this pull request Jan 29, 2021
@AntoineRondelet
Merge pull request #345 from clearmatics/input-hashing
e423bde 
Hash joinsplit public inputs (depends on #344)
@AntoineRondelet AntoineRondelet deleted the input-hashing-prepare branch February 19, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
zecale-integration Task related to the custom integration of Zeth with Zecale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet