-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docker build from DockerHub to GitHub Container Registry #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eastata - can we still manually push docker images to this registry? I'd like to push the "application images" for the 0.5 and 0.6 tags (which I guess, won't be re-built - or will they?) |
Yes. You have to configure docker client using GITHUB_TOKEN |
I see, thanks @eastata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @eastata!
The issue is a part of global migration from DockerHub to GitHub Container Registry.
Docker images for applications mpc, client, prover
linux/amd64
. List of platform can be extended for the futurevX.Y.Z
Base image still the same, only migrated to GitHub CR
docker-base-vX.Y.Z
Docker images
latest-prover
,X.Y.Z-prover
- Release of zeth,git-%HASH%-prover
- developers build by git-commitzeth-base
for buildinglatest-client
,X.Y.Z-client
- Release of zeth,git-%HASH%-client
- developers build by git-commitlatest-mpc
,X.Y.Z-mpc
- Release of zeth,git-%HASH%-mpc
- developers build by git-commitzeth-base
for buildinglatest-base
,A.B.C-base
- Release of zeth-base