Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts cleanup #361

Merged
merged 22 commits into from
Apr 29, 2021
Merged

Contracts cleanup #361

merged 22 commits into from
Apr 29, 2021

Commits on Apr 29, 2021

  1. Removed unused MerkleTreeSha256 contract which wasn't compiling

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    787498f View commit details
    Browse the repository at this point in the history

  2. Renamed functions in Pairing library to avoid collisions with assembl… 

    …y instructions
    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    da1ad42 View commit details
    Browse the repository at this point in the history

  3. Removed useless visisbility for constructors

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    d204cea View commit details
    Browse the repository at this point in the history

  4. Restricted hash functions to pure state mutability

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a4f8fe0 View commit details
    Browse the repository at this point in the history

  5. Renamed members in mixedCase

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    5e9af73 View commit details
    Browse the repository at this point in the history

  6. Fixed comment formatting and missing renamings

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    51b6947 View commit details
    Browse the repository at this point in the history

  7. Switched public functions to external when possible to read straight … 

    …from calldata
    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    51badde View commit details
    Browse the repository at this point in the history

  8. Fixed solidity linting issues and renamed functions in python tests

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    c660695 View commit details
    Browse the repository at this point in the history

  9. Restricted verifyZkProof state mutability and added explicit public s… 

    …cope
    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4d57e82 View commit details
    Browse the repository at this point in the history

  10. Fixed name styling and renaiming loose scopes

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    71872d9 View commit details
    Browse the repository at this point in the history

  11. Fixed inconsistent test function name

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    77b4834 View commit details
    Browse the repository at this point in the history

  12. Removed useless and deprecated files

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    fb950b6 View commit details
    Browse the repository at this point in the history

  13. Refined coding standards and cascaded changes to the code base

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4e863a0 View commit details
    Browse the repository at this point in the history

  14. Fixed erroneous signature of verifyZkProof function in tests

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    e1de582 View commit details
    Browse the repository at this point in the history

  15. Refactored _contract_name function in zeth cli backend to match solid… 

    …ity renamings
    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    77b4298 View commit details
    Browse the repository at this point in the history

  16. Renamed python class to match new solidity contract name

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    3bf2b7f View commit details
    Browse the repository at this point in the history

  17. Added requirement for virtual functions to be written last

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4b5921a View commit details
    Browse the repository at this point in the history

  18. Fixed erroneous renaming in comments

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    dd5f6e7 View commit details
    Browse the repository at this point in the history

  19. Updated the coding standards as per the discussion with DT

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    845123d View commit details
    Browse the repository at this point in the history

  20. Switched IERC20 to an interface

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    f261a9c View commit details
    Browse the repository at this point in the history

  21. Added compiler version to truffle config

    @AntoineRondelet
    AntoineRondelet committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    63fd3cd View commit details
    Browse the repository at this point in the history

  22. Fixed missed prefix update for libraries in coding standards 

    Co-authored-by: Duncan Tebbs <dtebbs@users.noreply.github.com>
    @AntoineRondelet @dtebbs
    AntoineRondelet and dtebbs committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    93e36c6 View commit details
    Browse the repository at this point in the history