Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some generated test data #365

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix some generated test data #365

merged 1 commit into from
Apr 27, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Apr 23, 2021

Some dummy data, namely groth16 proofs (generated with known values to test serialization), has incompatible sized elements which can cause errors in some cases.

@dtebbs dtebbs marked this pull request as ready for review April 23, 2021 09:24
@dtebbs dtebbs requested a review from AntoineRondelet as a code owner April 23, 2021 09:24
@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Apr 23, 2021

Some dummy data, namely groth16 proofs (generated with known values to test serialization), has incompatible sized elements which can cause errors in some cases.

Thanks @dtebbs - I don't quite follow though. In this PR you "extend" the A_query and B_query, what incompatibility does it fix? Likewise, what do you mean by which can cause errors in some cases? (why wasn't this raised on the CI by failing tests?)

@dtebbs
Copy link
Contributor Author

dtebbs commented Apr 23, 2021

Some dummy data, namely groth16 proofs (generated with known values to test serialization), has incompatible sized elements which can cause errors in some cases.

Thanks @dtebbs - I don't quite follow though. In this PR you "extend" the A_query and B_query, what incompatibility does it fix? Likewise, what do you mean by which can cause errors in some cases? (why wasn't this raised on the CI by failing tests?)

In general, serialization functions don't rely on the array lengths being consistent with each other, and so it doesn't really matter how long they are. When loading the RDD version of the proof object, indices and offsets are computed at deserialization time and stored alongside some of the elements, which requires these array lengths to be compatible with some specific primary and auxiliary input sizes.

(Hope that makes sense - let me know if still it's not clear.)

@AntoineRondelet
Copy link
Contributor

Thanks @dtebbs - I see.
LGTM, merging now.

@AntoineRondelet AntoineRondelet merged commit 28d901e into develop Apr 27, 2021
@AntoineRondelet AntoineRondelet deleted the fix-test-data branch April 29, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants