Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimc update to align with spec #369

Merged
merged 8 commits into from
May 5, 2021
Merged

Mimc update to align with spec #369

merged 8 commits into from
May 5, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Apr 29, 2021 •
edited
Loading

@dtebbs dtebbs force-pushed the mimc-constants-update branch 2 times, most recently from 8d0c199 to 6799d29 Compare April 29, 2021 16:15
@dtebbs dtebbs changed the base branch from master to prover-data-export April 29, 2021 16:16
@dtebbs dtebbs force-pushed the mimc-constants-update branch 2 times, most recently from 583c85c to bd5c746 Compare April 29, 2021 16:45
@dtebbs dtebbs mentioned this pull request Apr 30, 2021
Merged
@dtebbs dtebbs marked this pull request as ready for review April 30, 2021 08:18
@dtebbs dtebbs requested a review from AntoineRondelet as a code owner April 30, 2021 08:18
@dtebbs dtebbs removed the request for review from AntoineRondelet April 30, 2021 10:10
@dtebbs dtebbs changed the title Mimc update to align with spec [WIP] Mimc update to align with spec Apr 30, 2021
@dtebbs dtebbs force-pushed the mimc-constants-update branch from 051aae5 to 372eb22 Compare April 30, 2021 10:14
@dtebbs dtebbs requested a review from AntoineRondelet April 30, 2021 10:16
@dtebbs dtebbs changed the base branch from prover-data-export to develop April 30, 2021 10:16
@dtebbs dtebbs changed the title [WIP] Mimc update to align with spec Mimc update to align with spec Apr 30, 2021
@dtebbs
Copy link
Contributor Author

dtebbs commented Apr 30, 2021

Made independent of #368. May make sense to merge this first.

@dtebbs dtebbs force-pushed the mimc-constants-update branch 2 times, most recently from 8e35d08 to b51ea01 Compare April 30, 2021 12:06
AntoineRondelet
AntoineRondelet reviewed Apr 30, 2021
View reviewed changes
@dtebbs dtebbs force-pushed the mimc-constants-update branch from b51ea01 to 6e8bd76 Compare April 30, 2021 15:35
@dtebbs dtebbs force-pushed the mimc-constants-update branch 2 times, most recently from 716ef94 to 0f88073 Compare May 4, 2021 14:17
@dtebbs dtebbs force-pushed the mimc-constants-update branch from 64b3a6b to e873d19 Compare May 4, 2021 14:42
@dtebbs dtebbs requested a review from AntoineRondelet May 4, 2021 14:42
AntoineRondelet
AntoineRondelet approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRondelet AntoineRondelet merged commit e5d9059 into develop May 5, 2021
@AntoineRondelet AntoineRondelet mentioned this pull request May 5, 2021
Closed
3 tasks
@AntoineRondelet AntoineRondelet deleted the mimc-constants-update branch May 6, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet