Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert solc compile-from-source #375

Merged
merged 1 commit into from
May 6, 2021
Merged

Revert solc compile-from-source #375

merged 1 commit into from
May 6, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented May 6, 2021

No description provided.

@dtebbs dtebbs changed the base branch from master to develop May 6, 2021 13:35
@dtebbs dtebbs changed the title [WIP] Revert solc compile-from-source Revert solc compile-from-source May 6, 2021
@dtebbs dtebbs marked this pull request as ready for review May 6, 2021 13:36
@dtebbs dtebbs requested a review from AntoineRondelet as a code owner May 6, 2021 13:36
AntoineRondelet
AntoineRondelet approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - perfect, thanks @dtebbs, that removes a potential source of inconsistency.

@AntoineRondelet AntoineRondelet merged commit 3ae3e20 into develop May 6, 2021
@AntoineRondelet AntoineRondelet deleted the tmp-docker-ci-fix branch May 21, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet