Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ran codespell and fixed typos #415

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Ran codespell and fixed typos #415

merged 2 commits into from
Nov 3, 2021

Conversation

AntoineRondelet
Copy link
Contributor

@AntoineRondelet AntoineRondelet commented Nov 2, 2021 •
edited
Loading

Related to: #405

Ran:

codespell --skip ./client/env/*,./zeth_contracts/node_modules/*,./build/*,./zeth_contracts/env/*,./client/.mypy_cache/*,./.git/*,./depends/*,./mpc/.mypy_cache/* --ignore-words-list GroupT,keypair

and fixed detected typos.

@AntoineRondelet AntoineRondelet mentioned this pull request Nov 2, 2021
Merged
dtebbs
dtebbs approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to fix a comment (since we are touching that line anyway). Otherwise, LGTM.

libzeth/core/chacha_rng.cpp Outdated Show resolved Hide resolved
@AntoineRondelet @dtebbs
Fix comment format
cc1698b 
Co-authored-by: Duncan Tebbs <dtebbs@users.noreply.github.com>
@AntoineRondelet
Copy link
Contributor Author

One suggestion to fix a comment (since we are touching that line anyway). Otherwise, LGTM.

Thanks, committed

@dtebbs dtebbs mentioned this pull request Nov 3, 2021
Merged
4 tasks
@dtebbs dtebbs merged commit e2efe51 into develop Nov 3, 2021
@AntoineRondelet AntoineRondelet deleted the run-codespell branch November 4, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRondelet @dtebbs