Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPC] Optimizations for linear combination #48

Merged
merged 9 commits into from
Sep 3, 2019
Merged

[MPC] Optimizations for linear combination #48

merged 9 commits into from
Sep 3, 2019

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Aug 12, 2019 •
edited
Loading

Faster implementations of some MPC calculations.

Relies on some changes in libff and libfqfft (and hence libsnark). They are rather trivial and do not affect the existinng behavior.

@dtebbs dtebbs changed the title Optimizations for linear combination stage of MPC (depends on #41) [MPC] Optimizations for linear combination (depends on #41) Aug 12, 2019
@AntoineRondelet AntoineRondelet added the MPC Task related to the Multi-Party Computation protocol/code label Aug 13, 2019
@AntoineRondelet
Copy link
Contributor

Depends on #41

@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch 3 times, most recently from 55c20fb to e87610d Compare August 20, 2019 16:48
@dtebbs dtebbs changed the base branch from mpc to mpc-crs-generation August 21, 2019 10:53
@dtebbs dtebbs force-pushed the mpc-crs-generation branch 3 times, most recently from 1c8c45a to 158aa2a Compare August 21, 2019 11:33
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from e87610d to 8b9ab9f Compare August 21, 2019 11:35
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from c2306ed to 04f9632 Compare August 27, 2019 16:46
@AntoineRondelet AntoineRondelet mentioned this pull request Aug 27, 2019
Merged
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from 04f9632 to 97d2e2e Compare August 28, 2019 09:26
@dtebbs dtebbs force-pushed the mpc-crs-generation branch 4 times, most recently from d3aad6c to f900c92 Compare August 29, 2019 12:08
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from 97d2e2e to 4c75b6f Compare August 29, 2019 12:29
@dtebbs dtebbs mentioned this pull request Aug 29, 2019
Merged
@dtebbs dtebbs force-pushed the mpc-crs-generation branch 6 times, most recently from 9718bb9 to 2d30e1a Compare August 29, 2019 18:27
@dtebbs dtebbs force-pushed the mpc-crs-generation branch 2 times, most recently from 90bdbf4 to e7b6811 Compare August 30, 2019 08:41
@dtebbs dtebbs changed the base branch from mpc-crs-generation to mpc August 30, 2019 11:02
@dtebbs dtebbs changed the title [MPC] Optimizations for linear combination (depends on #41) [MPC] Optimizations for linear combination Aug 30, 2019
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from 4c75b6f to 62116f7 Compare August 30, 2019 12:16
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch 3 times, most recently from 0d52c38 to 16252b0 Compare August 30, 2019 14:19
AntoineRondelet
AntoineRondelet reviewed Sep 2, 2019
View reviewed changes
src/snarks/groth16/powersoftau_utils.cpp Outdated Show resolved Hide resolved
src/snarks/groth16/powersoftau_utils.cpp Outdated Show resolved Hide resolved
src/snarks/groth16/mpc_utils.tcc Outdated Show resolved Hide resolved
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch 2 times, most recently from 67d7b38 to f78ddb7 Compare September 2, 2019 12:33
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from f78ddb7 to 6b5fc39 Compare September 2, 2019 12:45
dtebbs
dtebbs commented Sep 2, 2019
View reviewed changes
Copy link
Contributor Author

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move the computation of the set {[t(x) . x^i]}, i in [0 .. n-2] as the first step of this function ...

I've moved the computation of {[t(x) . x^i]} to the start of the function.

src/snarks/groth16/powersoftau_utils.cpp Outdated Show resolved Hide resolved
@dtebbs dtebbs force-pushed the mpc-optimize-linear-combination branch from 6b5fc39 to 69ed607 Compare September 2, 2019 15:44
@AntoineRondelet AntoineRondelet merged commit 2f9fbce into mpc Sep 3, 2019
AntoineRondelet added a commit that referenced this pull request Sep 10, 2019
@AntoineRondelet
Merge pull request #67 from clearmatics/mpc-separate-utilities
61df562 
[MPC] Utilities for SRS generation via MPC (depends on #48)
@AntoineRondelet AntoineRondelet deleted the mpc-optimize-linear-combination branch September 20, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet left review comments

Assignees
No one assigned
Labels
CRS/SRS MPC Task related to the Multi-Party Computation protocol/code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet