Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting #62

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Code formatting #62

merged 3 commits into from
Aug 27, 2019

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Aug 22, 2019

Introduce a code-formatting tool to ensure style consistency across the code base.

src/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
@AntoineRondelet
Copy link
Contributor

This PR addresses issue #57

@dtebbs dtebbs force-pushed the code-formatting branch 4 times, most recently from a10e9c1 to b157c38 Compare August 23, 2019 10:30
@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 23, 2019

I did another iteration addressing a few places where the results of the formatting stood out. As before, I've pushed a final commit with the formatting.

I just did a very rough scan, so there are still bits of code that will be formatted strangely until somone manually addresses them (mainly comments at the end of lines). But we could address those later as the code is touched in future commits.

Let me know if anything stands out as wrong.

@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 27, 2019

I just have a few more places to fix, and then I'll remove the WIP from this PR.

@AntoineRondelet
Copy link
Contributor

The PR looks good to me. However I have a compilation issue:

snarks/groth16/computation.hpp:25:14: error: ‘extended_proof’ is not a member of ‘libzeth’
     libzeth::extended_proof<ppT> ext_proof,
              ^~~~~~~~~~~~~~

It might be an error with some of the "includes", maybe the extended_proof.hpp is not properly included in the computation.hpp

@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 27, 2019

It might be an error with some of the "includes"

Thanks. I think there were some circular includes shown up when clang-format reordered things. Should be fixed now, along with a rebasing error I introduced.

@dtebbs dtebbs changed the title WIP: Code formatting Code formatting Aug 27, 2019
@AntoineRondelet
Copy link
Contributor

Thanks a lot for that @dtebbs good to have some tooling to improve code consistency.
LGTM.

@AntoineRondelet AntoineRondelet merged commit 73f582b into develop Aug 27, 2019
@AntoineRondelet AntoineRondelet deleted the code-formatting branch September 4, 2019 08:28
AntoineRondelet added a commit that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants