Make the goal pose tool magenta #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to distinguish from the set pose tool.
|
Looks good to me. 👍 |
|
Upstream PR is filed. |
efernandez
approved these changes
Jun 18, 2020
|
@iwanders Works for me. I'm not going to discuss whether magenta is a good choice or not. 😄 I can merge it, should I? Or should I wait for another 👍 ? |
|
I think it's good to merge. I'll do it and tag it. Thanks for giving this 👍 all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to distinguish from the set pose tool.
For some reason I didn't have the power to push a new branch into clearpathrobotics/rviz, so had to make a PR to merge it into the branch we use.
@mikepurvis, You touched this branch last :)
@jasonimercer, @efernandez , @p6chen, @servos for some autonomy eyes to decide whether we like this.