Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check limits #85

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Health check limits #85

merged 4 commits into from
Oct 1, 2023

Conversation

andymckay
Copy link
Contributor

@andymckay andymckay commented Oct 1, 2023

Allow health checks to choose what services they want to run against.

It could be:

  • All (what it was before)
  • Some (allow you to chose what to include)
  • None (allow you to run a health check without any service attached)

The case for some is pretty straightforward, it avoids a health check result and Action being triggered on the server. Saving everyone some time.

The case for none is less straightforward, but you could have a health check unrelated to a service. For example, does everyone in the organisation have MFA enabled? In this case we need to make health check payload and results have service as optional.

To do:

  • update docs
  • an end to end test with an action

Backwards incompatible change: the command line management tasks were useful at the beginning but after moving to celery seemed pointless. Also there's a button in the UI so I'm not sure what purpose they served other than making code a bit more complicated, so I removed them.

@andymckay andymckay merged commit 2f92c03 into main Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant