Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to change framerate mid run #22

Closed
Matte27 opened this issue Dec 27, 2017 · 2 comments
Closed

Add an option to change framerate mid run #22

Matte27 opened this issue Dec 27, 2017 · 2 comments

Comments

@Matte27
Copy link

Matte27 commented Dec 27, 2017

Low priority but would be nice for meatboy all glitches

@clementgallet
Copy link
Owner

Most of the work done in 337fc9c

Still a few things to take care of:

  • Encoding is not supported
  • If there are computations of the movie length, they are now incorrect (check movie metadata)
  • I'm resetting the sub-nanosecond accumulator (used to compute the length of a frame) when framerate has changed, is that a problem? This accumulator is used when the length of a frame cannot be represented as a integer number of nanoseconds (smallest unit of time used in Linux), but the meaning of its value depends on the value of the framerate.
  • Displayed values when loading a savestate are incorrect (they look correct after advancing one frame)
  • Check if audio mixing is holding up

@clementgallet
Copy link
Owner

  • Fix the interaction with restart/auto_restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants