Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dosbox crash] load forked save state #407

Closed
InfamousKnight opened this issue Mar 27, 2021 · 2 comments
Closed

[Dosbox crash] load forked save state #407

InfamousKnight opened this issue Mar 27, 2021 · 2 comments

Comments

@InfamousKnight
Copy link

I stumbled across some forked save state feature and tried to use it under dosbox for testing.

From my understanding it lets you jump straight back to work? It saves the whole game process which is why it takes so long to save, but loading it crashes if you:

Record movie with forked save states checked
Advance like 30 frames
Type in some short word
Make a save state
Type in another word
End recording
Playback movie and try to load the save state from frame 3 or something.
After that, it crashes. Does not say "can't load state from previous execution"

I haven't checked the console log for it yet.

@InfamousKnight
Copy link
Author

Tried to reproduce, and couldn't...

What is that fork to save states do and what advantage does it have?

@clementgallet
Copy link
Owner

This feature creates a fork of the game. Then, this forked process proceeds to write its savestate, while the original process can resume immediately. This is used to prevent the freezing while the savestate is performed, but does not allow loading after game restart.

This has been fixed. The issue was: if you save a state with this feature and then immediately close the game, the savestates are erased, and then the forked process finishes writing the state. So there is a stalled savestate. On next launch, it was wrongly detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants