Add selectable savestates #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negative-seven
force-pushed
the
selectable_savestates
branch
from
a494b85
to
cd52c81
Compare
|
Force pushed with no changes to rerun checks, as they previously timed out and failed for unknown reasons. |
src/program/KeyMapping.h
Outdated
| @@ -77,6 +79,8 @@ typedef int HotKeyType; enum | |||
| HOTKEY_LOADBRANCH8, | |||
| HOTKEY_LOADBRANCH9, | |||
| HOTKEY_LOADBRANCH_BACKTRACK, | |||
| HOTKEY_SELECTSTATE_NEXT, | |||
| HOTKEY_SELECTSTATE_PREVIOUS, | |||
There was a problem hiding this comment.
We would want to append the extra hotkeys at the end, so that it does not shift existing hotkey mappings
There was a problem hiding this comment.
Thanks for noticing - I did not realize this. Maybe these enum values could be explicitly numbered to make that more apparant?
There was a problem hiding this comment.
Ah, just saw there is a comment about this at the top.
…wards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the concept of a "selected savestate", along with 4 hotkeys: two for incrementing and decrementing the selected slot, and two for saving and loading the selected state.
This is a feature present in the vast majority of rerecording console emulators, and, although I can't speak for others, it is my personally preferred method of managing savestates.