Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydra warnings #23

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

ylep
Copy link
Collaborator

@ylep ylep commented Oct 23, 2023

Description

Fix a couple of hydra-related warnings that appear at hsf start-up time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • OS: Ubuntu 22.04
  • Python version: 3.10.12
  • Any other relevant config detail: hydra-core==1.3.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ylep ylep added the enhancement New feature or request label Oct 23, 2023
@ylep ylep requested a review from clementpoiret October 23, 2023 14:55
@ylep
Copy link
Collaborator Author

ylep commented Oct 23, 2023

@clementpoiret it seems that the CI pipeline needs an update (the poetry install action dropped support for Python 3.7). Feel free to merge regardless or to wait for a proper fix, no hurry...

I can just tell you that tests pass locally on Python 3.10.12.

@clementpoiret
Copy link
Owner

Thanks for the update, I'll also update the CI pipeline :)

@clementpoiret clementpoiret merged commit 3919b1f into clementpoiret:master Oct 23, 2023
1 of 5 checks passed
@ylep ylep deleted the fix_hydra_warning branch October 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants