Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-segmenting already processed subjects #28

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

clementpoiret
Copy link
Owner

Description

This PR introduces an option to control the overwriting of already existing segmentations.
The new config is files.overwrite:

  • files.overwrite=False will skip subjects with segmentations in their parent folder.

A side effect of this PR is that segmentations that are included in glob patterns are removed from the list of mris to segment, which is a good behavior.

Fixes #27

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • See tests/

Test Configuration:

  • OS:
  • Python version:
  • Hardware:
  • Any other relevant config detail:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

deepsource-io bot commented Mar 29, 2024

Here's the code health analysis summary for commits 027e16f..eca176d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython❌ Failure
❗ 4 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@clementpoiret clementpoiret merged commit 3153901 into master Mar 29, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options to skip data that has been already segmented.
1 participant