-
Notifications
You must be signed in to change notification settings - Fork 867
ios - filter out UI components homepage #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios - filter out UI components homepage #2778
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@NWylynko Noticed this bug where I switch SDKs and it does switch from "UI components" to "Views", but then I get redirected to another page. Screen.Recording.2025-11-10.at.10.10.19.am.mov |
@SarahSoutoul This is pre-existing intentional behavior, only happens when on the home page, the idea is its the same as selecting one of the sdks from the "explore by frontend / backend framework" section |
| - [UI Components](/docs/reference/components/overview) | ||
| - Clerk's prebuilt UI components give you a beautiful, fully-functional user management experience in minutes. | ||
| - {<svg viewBox="0 0 32 32" fill="none"><path fill="currentColor" fillOpacity=".15" d="M16 31.25 1.962 25.234A2 2 0 0 1 .75 23.395V7.285l14.462-6.197a2 2 0 0 1 1.576 0L31.25 7.286 16 13.896V31.25Z"/><path fill="currentColor" d="m16 31.25-.295.69a.75.75 0 0 0 1.045-.69H16ZM1.962 25.234l-.295.69.295-.69ZM.75 7.286l-.295-.69a.75.75 0 0 0-.455.69h.75Zm30.5 0 .298.688a.75.75 0 0 0-.003-1.378l-.295.69ZM16.788 1.088l-.296.689.296-.69Zm-1.576 0 .296.689-.296-.69Zm1.083 29.473L2.258 24.544l-.591 1.38 14.038 6.015.59-1.378ZM1.5 23.395V7.285H0v16.11h1.5ZM31.545 6.596 17.083.398l-.59 1.379 14.462 6.198.59-1.379ZM14.917.398.455 6.596l.59 1.38 14.463-6.199-.591-1.379ZM.452 7.974l15.25 6.61.596-1.376-15.25-6.61-.596 1.376Zm15.846 6.61 15.25-6.61-.596-1.376-15.25 6.61.596 1.377Zm-1.048-.688V31.25h1.5V13.896h-1.5ZM17.083.399a2.75 2.75 0 0 0-2.166 0l.59 1.379a1.25 1.25 0 0 1 .985 0l.591-1.379ZM2.258 24.544a1.25 1.25 0 0 1-.758-1.149H0c0 1.1.656 2.095 1.667 2.528l.59-1.379Z"/><path stroke="currentColor" strokeLinecap="round" strokeLinejoin="round" strokeWidth="1.5" d="M31.25 7.281v16.11a2 2 0 0 1-1.212 1.838L16 31.246"/></svg>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the repetition of cards, could we not have the wrapping just this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to get that working (at least without making changes to the build docs script, I haven't taken a stab at that), but @manovotny is giving it a try to see if he can get that working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried:
- Wrapping the single line.
- Wrapping that single card.
- Using a partial.
None of them worked.
I'm sure there's changes we can make to Card rendering or traversing, but it's not immediately clear.
I sent @NWylynko the same thing. To his point, that's how it currently behaves. We can have a conversation about changing this behavior at a later point since it tripped both of us up. However, it is unrelated/separate to the changes in the PR. |
manovotny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After trying several alternatives and even some additional coding changes, there isn't a easier or better way to handle this at the moment.
@NWylynko I'll leave it up to you if you want to make the SVGs icon components or not. Otherwise, the rest of the changes look good.
83d892e
into
mike/mobile-307-change-documentation-terminology-to-views
on top of #2773
🔎 Previews:
What does this solve?
What changed?
<If />component to swap out the contents of the page based on the sdkChecklist