Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Enter changesets Pre mode (for v5) #1970

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 30, 2023

Description

  • Merge Version packages to produce next major version @alpha-v5 release
  • Rename references of main-v4 to release/v4 (are only used as reference for the future, those will actually be used to trigger flows when they are committed to release/v4)
  • Merging to main will not publish any version

To verify premajor tags:

  • git checkout fix-version-packages
  • npx changeset version
  • check Changelog and package.json changes

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Oct 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: db5a931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 13 packages
Name Type
gatsby-plugin-clerk Major
@clerk/clerk-js Major
@clerk/clerk-sdk-node Major
@clerk/backend Major
@clerk/fastify Major
@clerk/nextjs Major
@clerk/shared Major
@clerk/clerk-expo Major
@clerk/types Major
@clerk/chrome-extension Patch
@clerk/remix Patch
@clerk/clerk-react Patch
@clerk/localizations Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimkl dimkl requested a review from nikosdouvlis October 30, 2023 11:55
@dimkl dimkl force-pushed the fix-version-packages branch 3 times, most recently from 0c9a367 to 387a803 Compare October 31, 2023 20:24
@dimkl dimkl changed the title Fix version packages chore(repo): Fix version packages Oct 31, 2023
@dimkl dimkl force-pushed the fix-version-packages branch from 387a803 to 3f83492 Compare October 31, 2023 20:28
@dimkl dimkl requested a review from LekoArts October 31, 2023 20:29
@dimkl dimkl mentioned this pull request Oct 31, 2023
24 tasks
@dimkl dimkl requested a review from LekoArts November 1, 2023 08:25
@dimkl dimkl force-pushed the fix-version-packages branch 3 times, most recently from 629773b to 543e69b Compare November 1, 2023 11:40
@LekoArts LekoArts changed the title chore(repo): Fix version packages chore(repo): Enter changesets Pre mode (for v5) Nov 1, 2023
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, everything else makes sense!

@dimkl dimkl force-pushed the fix-version-packages branch 2 times, most recently from 4dbb3c7 to aef6c94 Compare November 1, 2023 12:02
@dimkl dimkl requested a review from LekoArts November 1, 2023 12:04
dimkl added 5 commits November 1, 2023 14:20
Since we are using the pre-release changeset mode there is no need to
generate canary releases upon merging commits to main using the `canary`
related npm commands and gh actions.
Also with this change we will stop producing a `canary` version on every
main merge.
Since we have enabled the changeset pre-release mode the versions
produced by the Version packages PR will be pre-release tags with
a `alpha-v${next-major-version}` tag. So there is no need to block the Version Packages
PR from being merged and we will need to exit changeset pre-release
mode to release the stable next major version.
@dimkl dimkl force-pushed the fix-version-packages branch from 427ff92 to db5a931 Compare November 1, 2023 12:22
@dimkl dimkl enabled auto-merge November 1, 2023 12:22
@dimkl dimkl added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit f8ddc02 Nov 1, 2023
@dimkl dimkl deleted the fix-version-packages branch November 1, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants