Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types,clerk-js,clerk-react): Deprecate Clerk.isReady() in favor of Clerk.loaded #2293

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Dec 8, 2023

Description

Deprecate Clerk.isReady() in favor of Clerk.loaded

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Dec 8, 2023
@dimkl dimkl requested a review from a team as a code owner December 8, 2023 12:31
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: ea37c92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/clerk-react Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl force-pushed the sdk-1036-deprecate-clerk-is-ready branch from 80f55ac to e78a106 Compare December 8, 2023 12:59
@dimkl dimkl force-pushed the sdk-1036-deprecate-clerk-is-ready branch from e78a106 to ea37c92 Compare December 8, 2023 13:01
@dimkl dimkl enabled auto-merge December 8, 2023 13:03
@dimkl dimkl added this pull request to the merge queue Dec 8, 2023
Merged via the queue into release/v4 with commit a624798 Dec 8, 2023
7 checks passed
@dimkl dimkl deleted the sdk-1036-deprecate-clerk-is-ready branch December 8, 2023 13:12
dimkl added a commit that referenced this pull request Dec 22, 2023
…` in favor of `Clerk.loaded` (#2293)"

This reverts commit a624798.
dimkl added a commit that referenced this pull request Dec 22, 2023
…` in favor of `Clerk.loaded` (#2293)"

This reverts commit a624798.
nikosdouvlis pushed a commit that referenced this pull request Dec 22, 2023
…` in favor of `Clerk.loaded` (#2293)" (#2441)

This reverts commit a624798.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants