fix(nextjs): Ensure package works with next 12 #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91703d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BRKalow
commented
Jan 22, 2024
Comment on lines
+54
to
+55
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const { notFound, redirect } = require('next/navigation'); |
There was a problem hiding this comment.
auth() should never be used in v12, but due to the module structure of the package and the unconditional import of next/navigation, in a CJS environment node was trying to resolve the next/navigation import. Shifting this inline fixes it.
|
!snapshot |
|
Hey @BRKalow - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/nextjs@4.29.5-snapshot.v91703d8 --save-exact |
BRKalow
changed the title
nikosdouvlis
approved these changes
Jan 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust how we import
next/navigationin theauth()helper to ensure our package can be safely imported in Next.js v12. The current recommended approach to usewebpack.IgnorePlugindoesn't when the package is externally required in a CJS environment.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore