Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Sms phone code verification lists available phone numbers on cancel #3479

Conversation

panteliselef
Copy link
Member

Description

Before

Screen.Recording.2024-05-23.at.13.24.34.mov

After

Screen.Recording.2024-05-31.at.2.09.08.PM.mov

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef requested a review from desiprisg May 31, 2024 11:12
@panteliselef panteliselef self-assigned this May 31, 2024
Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: 65c2faf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef enabled auto-merge (squash) May 31, 2024 17:54
@panteliselef panteliselef merged commit f31e382 into main May 31, 2024
11 checks passed
@panteliselef panteliselef deleted the elef/sdk-1772-2fa-phone-selection-screen-should-re-show-on-cancel branch May 31, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants