feat(clerk-js,react,types): Add option to enable combined flow at component level #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06e4192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
changed the base branch from
main
to
alexcarpenter/sign-in-or-up-ga
BRKalow
reviewed
Jan 9, 2025
alexcarpenter
commented
Jan 10, 2025
panteliselef
approved these changes
Jan 13, 2025
dstaley
reviewed
Jan 13, 2025
| @@ -121,6 +123,6 @@ export const useSignInContext = (): SignInContextType => { | |||
| queryParams, | |||
| initialValues: { ...ctx.initialValues, ...initialValuesFromQueryParams }, | |||
| authQueryString: redirectUrls.toSearchParams().toString(), | |||
| isCombinedFlow, | |||
| isCombinedFlow: isCombinedFlow ?? false, | |||
There was a problem hiding this comment.
can we move this null operator into the definition for isCombinedFlow?
alexcarpenter
merged commit 39aae7d
into
alexcarpenter/sign-in-or-up-ga
6 checks passed
alexcarpenter
deleted the
alexcarpenter/sdki-812-allow-enabling-combinedflow-at-signin-component-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to opt in a single
<SignIn />component instance to a combined flow.Resolves SDKI-812
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change