Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Improve keyless prompt accessibility #4806

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

fix(clerk-js): Improve keyless prompt accessibility #4806

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4feda4c
Remove minimize button, open link in new tab
kaftarmery Dec 18, 2024
a32a33d
Handle keyboard expansion
kaftarmery Dec 18, 2024
a5c87f8
Checkpoint
kaftarmery Dec 18, 2024
b6e48b3
Changeset
kaftarmery Dec 18, 2024
aea0087
Merge branch 'main' into mery/update-ui
kaftarmery Dec 18, 2024
94da83b
WIP
kaftarmery Dec 18, 2024
87c3a99
Add skip link, reduce motion
kaftarmery Dec 19, 2024
72e3fc2
.
kaftarmery Dec 19, 2024
3bfbff3
Merge branch 'main' into mery/update-ui
kaftarmery Dec 19, 2024
e359eb6
Move skip link up the DOM
kaftarmery Dec 19, 2024
6540538
Less animation
kaftarmery Dec 19, 2024
c7948f5
WIP
kaftarmery Dec 19, 2024
f1396f0
Improvements
kaftarmery Dec 20, 2024
e9aea8f
Tweak missing env description
kaftarmery Dec 20, 2024
c642d70
Fix
kaftarmery Dec 20, 2024
c0687f4
render skip link
panteliselef Dec 20, 2024
fdf6e1c
Insert skip link
kaftarmery Dec 20, 2024
8619dc7
Merge branch 'main' into mery/update-ui
kaftarmery Dec 20, 2024
f787b0f
Change skip link text
kaftarmery Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-news-enjoy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Improve keyless prompt accessibility based on feedback
7 changes: 7 additions & 0 deletions packages/clerk-js/sandbox/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@
</script>
</head>
<body class="flex min-h-full flex-col overflow-x-hidden bg-gray-50">
<a
href="#keyless-prompt-button"
class="fixed -left-[999px] top-4 z-[999999] rounded-md bg-white px-2 py-1 text-sm text-black underline focus:left-4 focus:outline focus:outline-2 focus:outline-offset-2"
>
Skip to keyless mode content
</a>

<div class="fixed inset-y-0 left-0 w-72 overflow-y-auto border-r border-gray-100 bg-white px-2 py-4">
<header class="mb-2 flex items-center justify-center gap-x-2 border-b border-gray-100 pb-4">
<svg
Expand Down
Loading
Loading