fix(clerk-js): Improve UX when adding adding phone MFA #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 81d2ffd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/user-675-user-confusion-on-how-to-use-an-existing-phone-number-as-mfa
branch
from
36baf18 to
c9edb75
Compare
anagstef
reviewed
Jan 9, 2025
kostaspt
approved these changes
Jan 10, 2025
octoper
force-pushed
the
vaggelis/user-675-user-confusion-on-how-to-use-an-existing-phone-number-as-mfa
branch
from
738efe9 to
81d2ffd
Compare
octoper
force-pushed
the
vaggelis/user-675-user-confusion-on-how-to-use-an-existing-phone-number-as-mfa
branch
from
81d2ffd to
e598d63
Compare
octoper
deleted the
vaggelis/user-675-user-confusion-on-how-to-use-an-existing-phone-number-as-mfa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the UX when adding a new phone as an MFA strategy, after the changes when verifying a phone number it will automatically be added as an MFA option
Before
CleanShot.2025-01-09.at.19.59.42.mp4
After
CleanShot.2025-01-09.at.19.55.16.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change