Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Runs email-link tests #4873

Merged
merged 9 commits into from
Jan 13, 2025
Merged

fix(e2e): Runs email-link tests #4873

merged 9 commits into from
Jan 13, 2025

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Jan 10, 2025

Description

This PR updates the email-link.test.ts file to contain a tag @generic and configs to actually run the tests. Previously these tests were not being run due to the missing tag and configs.

It also updates the Turborepo config to pass the MAILSAC_API_KEY for the generic and nextjs integration tests.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:00pm

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 9f1330e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dstaley dstaley changed the title fix(tests): Runs email-link tests fix(e2e): Runs email-link tests Jan 10, 2025
@dstaley dstaley merged commit 196f141 into main Jan 13, 2025
31 checks passed
@dstaley dstaley deleted the ds.fix/run-email-link-tests branch January 13, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants