Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shared,react-router,tanstack-start): Create shared environment variable retrieval function #4985
chore(shared,react-router,tanstack-start): Create shared environment variable retrieval function #4985
Changes from all commits
23db855
f756662
029dce0
7f808fa
f1ce19b
9f486ca
a876fa7
2a1bd48
d85c375
78804b9
a7cb5a9
585ff10
b8f584a
ca4aafa
fa68dae
0cb3adb
58c1fdd
df3533b
5152f78
7b44219
d09261d
2ea0a3e
f8305f6
15b7417
8431042
1f6bff3
db1427e
01ba102
71ff504
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the introduction of
es2020
target, would it make sense to publish a minor version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support
import.meta.env
, esbuild needs a target ofes2020
or above